Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor(profiles): pass profile to Wallet and Contact #494

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

faustbrian
Copy link
Contributor

Resolves #490

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #494 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   73.51%   73.59%   +0.07%     
==========================================
  Files          50       52       +2     
  Lines        1012     1049      +37     
  Branches       72       76       +4     
==========================================
+ Hits          744      772      +28     
- Misses        241      248       +7     
- Partials       27       29       +2     
Flag Coverage Δ
#unit 73.59% <100.00%> (+0.07%) ⬆️
Impacted Files Coverage Δ
packages/platform-sdk-profiles/src/contact.ts 100.00% <100.00%> (ø)
packages/platform-sdk-profiles/src/profile.ts 91.30% <100.00%> (ø)
...dk-profiles/src/repositories/contact-repository.ts 94.73% <100.00%> (+0.29%) ⬆️
...sdk-profiles/src/repositories/wallet-repository.ts 84.84% <100.00%> (+0.47%) ⬆️
packages/platform-sdk-profiles/src/wallet.ts 61.70% <100.00%> (+0.83%) ⬆️
packages/platform-sdk-atom/src/utils/hash.ts 36.36% <0.00%> (ø)
packages/platform-sdk-atom/src/utils/crypto.ts 88.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8668b...b3defd2. Read the comment docs.

Brian Faust added 2 commits June 29, 2020 07:31
@faustbrian faustbrian marked this pull request as ready for review June 29, 2020 07:21
@faustbrian faustbrian merged commit 86c4e4f into master Jun 29, 2020
@faustbrian faustbrian deleted the passprofile branch June 29, 2020 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass profile to wallets and contacts
1 participant