Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

feat: implement is* methods to determine transaction types #511

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jul 2, 2020

Resolves #509
Resolves #510

Leaves some methods to return static values until the coins are integrated into wallets.

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #511 into master will increase coverage by 9.65%.
The diff coverage is 10.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage   59.72%   69.38%   +9.65%     
==========================================
  Files          34       57      +23     
  Lines         509     1166     +657     
  Branches       43       83      +40     
==========================================
+ Hits          304      809     +505     
- Misses        191      325     +134     
- Partials       14       32      +18     
Flag Coverage Δ
#unit 69.38% <10.41%> (+9.65%) ⬆️
Impacted Files Coverage Δ
packages/platform-sdk-profiles/src/cache.ts 86.95% <ø> (ø)
...platform-sdk/src/coins/collections/transactions.ts 0.00% <0.00%> (ø)
packages/platform-sdk-profiles/src/transaction.ts 2.56% <2.56%> (ø)
packages/platform-sdk-profiles/src/wallet.ts 63.15% <25.00%> (ø)
...s/platform-sdk-profiles/src/transaction.helpers.ts 75.00% <75.00%> (ø)
packages/platform-sdk-profiles/src/storage/null.ts 100.00% <0.00%> (ø)
...dk-profiles/src/repositories/setting-repository.ts 90.90% <0.00%> (ø)
...ofiles/src/repositories/notification-repository.ts 95.65% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd93912...30b5fee. Read the comment docs.

@faustbrian faustbrian force-pushed the is-methods branch 4 times, most recently from 68e22ee to ed49370 Compare July 3, 2020 02:03
@faustbrian faustbrian marked this pull request as ready for review July 3, 2020 02:09
@faustbrian faustbrian merged commit 85d09e1 into master Jul 3, 2020
@faustbrian faustbrian deleted the is-methods branch July 3, 2020 02:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Transaction#isReceived Implement Transaction#isSent
1 participant