Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor(eos): migrate from eosjs-ecc to elliptic #535

Merged
merged 6 commits into from
Jul 17, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jul 17, 2020

Resolves #532

Brian Faust added 2 commits July 17, 2020 08:19
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #535 into master will increase coverage by 9.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
+ Coverage   69.23%   79.23%   +9.99%     
==========================================
  Files          58       40      -18     
  Lines        1180     1016     -164     
  Branches       85       80       -5     
==========================================
- Hits          817      805      -12     
+ Misses        331      179     -152     
  Partials       32       32              
Flag Coverage Δ
#unit 79.23% <100.00%> (+9.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/platform-sdk-eos/src/crypto.ts 100.00% <100.00%> (ø)
...ckages/platform-sdk/src/coins/collections/index.ts
...platform-sdk/src/coins/collections/transactions.ts
packages/platform-sdk/src/data/index.ts
packages/platform-sdk/src/coins/coin-factory.ts
...s/platform-sdk-btc/src/utils/unspent-aggregator.ts
packages/platform-sdk/src/coins/index.ts
packages/platform-sdk/src/coins/guard.ts
packages/platform-sdk/src/data/currencies.ts
packages/platform-sdk/src/contracts/coins/index.ts
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65332ff...e7b24b4. Read the comment docs.

Brian Faust added 2 commits July 17, 2020 08:31
@faustbrian faustbrian marked this pull request as ready for review July 17, 2020 05:36
@faustbrian faustbrian merged commit 6d96fe9 into master Jul 17, 2020
@faustbrian faustbrian deleted the eos-ecc branch July 17, 2020 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from eosjs-ecc to elliptic
1 participant