Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: implement fluent interface for HTTP clients #553

Merged
merged 12 commits into from Jul 20, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

Resolves #550

@faustbrian faustbrian marked this pull request as draft July 20, 2020 08:20
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #553 into master will decrease coverage by 38.76%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #553       +/-   ##
===========================================
- Coverage   70.17%   31.41%   -38.77%     
===========================================
  Files          59       33       -26     
  Lines        1187      347      -840     
  Branches       82       23       -59     
===========================================
- Hits          833      109      -724     
+ Misses        324      235       -89     
+ Partials       30        3       -27     
Flag Coverage Δ
#unit 31.41% <0.00%> (-38.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/platform-sdk-btc/src/utils/unspent-aggregator.ts 0.00% <0.00%> (ø)
packages/platform-sdk/src/http/exceptions.ts 0.00% <0.00%> (ø)
packages/platform-sdk/src/http/helpers.ts 0.00% <0.00%> (ø)
packages/platform-sdk/src/http/index.ts 0.00% <0.00%> (ø)
packages/platform-sdk/src/http/request.ts 0.00% <0.00%> (ø)
packages/platform-sdk/src/http/response.ts 0.00% <0.00%> (ø)
packages/platform-sdk-profiles/src/profile.ts
...ofiles/src/repositories/notification-repository.ts
packages/platform-sdk-profiles/src/cache.ts
packages/platform-sdk-profiles/src/env.ts
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2486aef...d770165. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review July 20, 2020 10:57
@faustbrian faustbrian merged commit d510108 into master Jul 20, 2020
@faustbrian faustbrian deleted the fluent-http branch July 20, 2020 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require fluent interface for HTTP client
1 participant