Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

chore(xlm): remove sodium-native dependency #565

Merged
merged 1 commit into from
Jul 23, 2020
Merged

chore(xlm): remove sodium-native dependency #565

merged 1 commit into from
Jul 23, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jul 23, 2020

Resolves the XLM part of #564

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #565 into master will increase coverage by 13.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #565       +/-   ##
===========================================
+ Coverage   51.95%   65.13%   +13.18%     
===========================================
  Files          48       74       +26     
  Lines         664     1374      +710     
  Branches       59      104       +45     
===========================================
+ Hits          345      895      +550     
- Misses        305      446      +141     
- Partials       14       33       +19     
Flag Coverage Δ
#unit 65.13% <ø> (+13.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/platform-sdk-profiles/src/avatar.ts 100.00% <0.00%> (ø)
...ackages/platform-sdk-profiles/src/storage/local.ts 90.47% <0.00%> (ø)
...ckages/platform-sdk-profiles/src/storage/memory.ts 100.00% <0.00%> (ø)
packages/platform-sdk-profiles/src/network.ts 100.00% <0.00%> (ø)
...kages/platform-sdk-profiles/src/contact-address.ts 56.52% <0.00%> (ø)
packages/platform-sdk-profiles/src/cache.ts 86.95% <0.00%> (ø)
packages/platform-sdk-profiles/src/storage/null.ts 100.00% <0.00%> (ø)
...ages/platform-sdk-profiles/src/container.models.ts 100.00% <0.00%> (ø)
...s/platform-sdk-profiles/src/transaction.helpers.ts 75.00% <0.00%> (ø)
...dk-profiles/src/repositories/profile-repository.ts 88.23% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318d7ca...1467f80. Read the comment docs.

@faustbrian faustbrian merged commit 7900eaf into master Jul 23, 2020
@faustbrian faustbrian deleted the sodium branch July 23, 2020 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant