Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

fix(profiles): modify contact instance instead of object #572

Merged
merged 5 commits into from
Jul 24, 2020

Conversation

faustbrian
Copy link
Contributor

No description provided.

Brian Faust added 3 commits July 24, 2020 13:17
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #572 into master will decrease coverage by 13.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #572       +/-   ##
===========================================
- Coverage   65.21%   51.95%   -13.26%     
===========================================
  Files          74       48       -26     
  Lines        1374      664      -710     
  Branches      104       59       -45     
===========================================
- Hits          896      345      -551     
+ Misses        446      305      -141     
+ Partials       32       14       -18     
Flag Coverage Δ
#unit 51.95% <ø> (-13.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/platform-sdk-profiles/src/network.ts
...ages/platform-sdk-profiles/src/container.models.ts
...s/platform-sdk-profiles/src/transaction.helpers.ts
...ackages/platform-sdk-profiles/src/wallet.models.ts
packages/platform-sdk-profiles/src/migrator.ts
packages/platform-sdk-profiles/src/env.ts
packages/platform-sdk-profiles/src/profile.ts
packages/platform-sdk-profiles/src/cache.ts
...kages/platform-sdk-profiles/src/contact-address.ts
packages/platform-sdk-profiles/src/storage/null.ts
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2beb480...1e0c129. Read the comment docs.

Brian Faust added 2 commits July 24, 2020 13:31
@faustbrian faustbrian merged commit 56cf84b into master Jul 24, 2020
@faustbrian faustbrian deleted the object-contact branch July 24, 2020 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant