Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor(profiles): treat the profile name as a setting #582

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

faustbrian
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #582 into master will decrease coverage by 13.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #582       +/-   ##
===========================================
- Coverage   65.82%   52.52%   -13.30%     
===========================================
  Files          77       49       -28     
  Lines        1425      672      -753     
  Branches      108       60       -48     
===========================================
- Hits          938      353      -585     
+ Misses        452      305      -147     
+ Partials       35       14       -21     
Flag Coverage Δ
#unit 52.52% <ø> (-13.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/platform-sdk-profiles/src/cache.ts
packages/platform-sdk-profiles/src/wallet.ts
packages/platform-sdk-profiles/src/avatar.ts
...ackages/platform-sdk-profiles/src/wallet.models.ts
...m-sdk-profiles/src/repositories/data-repository.ts
packages/platform-sdk-profiles/src/contact.ts
...kages/platform-sdk-profiles/src/contact-address.ts
...ackages/platform-sdk-profiles/src/storage/local.ts
...dk-profiles/src/repositories/setting-repository.ts
packages/platform-sdk-profiles/src/storage/null.ts
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea85ebc...77a07b4. Read the comment docs.

@faustbrian faustbrian merged commit 3654f77 into master Jul 29, 2020
@faustbrian faustbrian deleted the profile-name branch July 29, 2020 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant