Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor(profiles): return type-specific transaction DTOs #592

Merged
merged 5 commits into from
Jul 30, 2020

Conversation

faustbrian
Copy link
Contributor

No description provided.

Brian Faust added 2 commits July 30, 2020 06:17
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #592 into master will decrease coverage by 0.71%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   66.10%   65.39%   -0.72%     
==========================================
  Files          77       79       +2     
  Lines        1437     1465      +28     
  Branches      110      130      +20     
==========================================
+ Hits          950      958       +8     
- Misses        452      472      +20     
  Partials       35       35              
Flag Coverage Δ
#unit 65.39% <0.00%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/platform-sdk-profiles/src/read-only-wallet.ts 0.00% <0.00%> (ø)
packages/platform-sdk-profiles/src/wallet.ts 60.18% <0.00%> (-3.28%) ⬇️
...platform-sdk/src/coins/collections/transactions.ts 0.00% <0.00%> (ø)
packages/platform-sdk/src/helpers.ts 0.00% <0.00%> (ø)
packages/platform-sdk-news/src/blockfolio.ts 100.00% <0.00%> (ø)
packages/platform-sdk-news/src/feed.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af29962...ec2e0b3. Read the comment docs.

Brian Faust added 3 commits July 30, 2020 08:25
@faustbrian faustbrian marked this pull request as ready for review July 30, 2020 06:11
@faustbrian faustbrian merged commit 6bd1227 into master Jul 30, 2020
@faustbrian faustbrian deleted the read-only-wallet branch July 30, 2020 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant