Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

fix(support): call toFixed with argument if argument is 0 #640

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Conversation

dated
Copy link
Contributor

@dated dated commented Aug 5, 2020

Summary

According to https://mikemcl.github.io/bignumber.js/#toFix num.toFixed() !== num.toFixed(0).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner August 5, 2020 07:29
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #640 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   49.52%   49.66%   +0.13%     
==========================================
  Files          53       53              
  Lines         739      741       +2     
  Branches       81       81              
==========================================
+ Hits          366      368       +2     
  Misses        359      359              
  Partials       14       14              
Flag Coverage Δ
#unit 49.66% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/platform-sdk-support/src/bignumber.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6473a89...1275bf5. Read the comment docs.

@faustbrian faustbrian merged commit 5538dc6 into ArkEcosystemArchive:master Aug 5, 2020
@dated dated deleted the patch-1 branch August 5, 2020 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants