Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

feat: verify that expected and actual sender of transactions are a match #651

Merged
merged 3 commits into from Aug 10, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 10, 2020

Resolves #636

@faustbrian faustbrian changed the title wip feat: verify that expected and actual sender of transactions are a match Aug 10, 2020
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #651 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   68.33%   68.30%   -0.03%     
==========================================
  Files          89       90       +1     
  Lines        1740     1751      +11     
  Branches      165      169       +4     
==========================================
+ Hits         1189     1196       +7     
- Misses        502      504       +2     
- Partials       49       51       +2     
Flag Coverage Δ
#unit 68.30% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/platform-sdk-coincap/src/utils.ts 63.63% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fedc5d...0027f13. Read the comment docs.

@faustbrian faustbrian merged commit 837b68c into master Aug 10, 2020
@faustbrian faustbrian deleted the verify-sender branch August 10, 2020 04:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate that the transaction sender is the same as the wallet
1 participant