Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: throw exception if HTTP request fails #689

Merged
merged 4 commits into from
Sep 2, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

No description provided.

@faustbrian faustbrian changed the title wip refactor(ark): throw exception if HTTP request fails Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #689 into master will decrease coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   63.08%   62.80%   -0.28%     
==========================================
  Files         104      102       -2     
  Lines        2205     2194      -11     
  Branches      240      239       -1     
==========================================
- Hits         1391     1378      -13     
- Misses        734      736       +2     
  Partials       80       80              
Flag Coverage Δ
#unit 62.80% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/platform-sdk/src/http/response.ts 0.00% <0.00%> (ø)
packages/platform-sdk-news/src/feed.ts
packages/platform-sdk-news/src/blockfolio.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca46d84...25fabc1. Read the comment docs.

@faustbrian faustbrian changed the title refactor(ark): throw exception if HTTP request fails refactor: throw exception if HTTP request fails Sep 1, 2020
@faustbrian faustbrian merged commit 25feb1b into master Sep 2, 2020
@faustbrian faustbrian deleted the ark-throw branch September 2, 2020 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant