Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

feat(profiles): aggregate developer registrations #694

Closed
wants to merge 5 commits into from

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Sep 3, 2020

Summary

Add support for profile.entityRegistrationAggregate().developers()

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #694 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   63.00%   63.17%   +0.16%     
==========================================
  Files         104      104              
  Lines        2211     2213       +2     
  Branches      242      242              
==========================================
+ Hits         1393     1398       +5     
+ Misses        737      736       -1     
+ Partials       81       79       -2     
Flag Coverage Δ
#unit 63.17% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ofiles/aggregates/entity-registration-aggregate.ts 75.00% <100.00%> (+3.57%) ⬆️
...kages/platform-sdk-profiles/src/helpers/promise.ts 62.50% <0.00%> (+4.16%) ⬆️
...ofiles/src/profiles/aggregates/entity-aggregate.ts 73.68% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee75816...e6b3e1b. Read the comment docs.

@faustbrian
Copy link
Contributor

Closing this because there will be a proper implementation coming soon to support all types and sub-types.

@faustbrian faustbrian closed this Sep 3, 2020
@faustbrian faustbrian deleted the feat/developers-entity-aggregate branch September 3, 2020 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants