Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor(profiles): set defaults when creating profile #699

Merged
merged 3 commits into from
Sep 7, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 7, 2020

Summary

Sets the default values when creating a profile, as to not rely on frontend applications to do that.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated changed the title refactor: set defaults when creating profile refactor(profiles): set defaults when creating profile Sep 7, 2020
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #699 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   64.94%   64.93%   -0.02%     
==========================================
  Files          99       99              
  Lines        2168     2170       +2     
  Branches      240      240              
==========================================
+ Hits         1408     1409       +1     
  Misses        678      678              
- Partials       82       83       +1     
Flag Coverage Δ
#unit 64.93% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/platform-sdk-profiles/src/profiles/profile.ts 98.79% <100.00%> (+0.01%) ⬆️
...dk-profiles/src/repositories/profile-repository.ts 79.54% <100.00%> (+0.47%) ⬆️
.../src/environment/services/exchange-rate-service.ts 90.47% <0.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef6685...4c59ef8. Read the comment docs.

@faustbrian faustbrian merged commit 26896ae into master Sep 7, 2020
@faustbrian faustbrian deleted the refactor/profile branch September 7, 2020 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants