-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
@@ -0,0 +1,56 @@ | |||
describe('Channels', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole __tests__
folder should be moved up to the top-level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faustbrian The project is bootstrapped with Create React App and requires the __tests__
folder to be placed inside the src
folder. If you move the folder to the root it will create all kinds of problems and would need quite some extra work to get it working properly. Worst case scenario an eject is necessary, and this would not work well with the goals set out for this project.
|
The app supports Markdown. So if you apply markdown syntax to your message input, you can preview it with this modal. Perhaps I should rename the preview to "Markdown preview" (it will also serve as a small hint that Markdown is supported that way)
Will do.
I believe it's a small error in the custom transaction, where it rejects a tx if the sender already is in the pool (forgot to omit it when using the register business transaction as a template)
Will look into it.
The app supports Markdown. So if you apply markdown syntax to your message input, you can preview it with this modal. Perhaps I should rename the preview to "Markdown preview" (it will also serve as a small hint that Markdown is supported that way)
Will do.
This is true. However, as discussed in the chat with Michel a little while ago, it is indeed an issue, but also considered out of scope for now. Thanks for the extensive feedback and will get back to it soon! 👍 |
chore: initial version (#1)
This PR pushes the the initial version (0.8.0) of the ARK messenger client to the repository.