Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: utilize environment variables #7

Merged
merged 5 commits into from Feb 12, 2020

Conversation

@Lemii
Copy link
Contributor

Lemii commented Feb 11, 2020

This PR moves the configuration and constants previoustly stored in config.ts and constants.ts to .env files. Sensitive data is stored in gitignored .env.development and .env.production files.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 11, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

Lemii added 2 commits Feb 11, 2020
@Lemii Lemii mentioned this pull request Feb 11, 2020
@faustbrian faustbrian merged commit 0fd11c4 into ArkEcosystem:master Feb 12, 2020
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 12, 2020

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.