Skip to content
This repository has been archived by the owner on Sep 26, 2020. It is now read-only.

refactor: error handling #29

Merged
merged 13 commits into from Dec 24, 2018
Merged

refactor: error handling #29

merged 13 commits into from Dec 24, 2018

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Dec 23, 2018

Proposed changes

Gets rid of unwrap in favor of a custom Error enum. Now the client won't panic anymore in case of a wrong response.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@faustbrian faustbrian merged commit d20757e into ArkEcosystemArchive:develop Dec 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants