Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

feat: Add fees endpoint for Node class #31

Merged
merged 1 commit into from May 27, 2019
Merged

feat: Add fees endpoint for Node class #31

merged 1 commit into from May 27, 2019

Conversation

Highjhacker
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented May 27, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. labels May 27, 2019
@codecov-io
Copy link

Codecov Report

Merging #31 into master will decrease coverage by 0.23%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   97.61%   97.38%   -0.24%     
==========================================
  Files          19       19              
  Lines         839      841       +2     
==========================================
  Hits          819      819              
- Misses         20       22       +2
Impacted Files Coverage Δ
Client/Client/Api/Endpoints/Node.swift 84.61% <0%> (-15.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a70157...f0fd662. Read the comment docs.

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label May 27, 2019
@ghost
Copy link

ghost commented May 27, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label May 27, 2019
@faustbrian faustbrian changed the title feat: Added fees endpoint for Node class feat: Add fees endpoint for Node class May 27, 2019
@faustbrian faustbrian merged commit a0bcaf0 into ArkEcosystemArchive:master May 27, 2019
@ghost
Copy link

ghost commented May 27, 2019

Your pull request has been merged and marked as tier 4. It will earn you $10 USD.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants