Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor curl dependency #45

Closed
ciband opened this issue Dec 29, 2018 · 4 comments · Fixed by #90
Closed

Refactor curl dependency #45

ciband opened this issue Dec 29, 2018 · 4 comments · Fixed by #90
Labels
Type: Refactor The pull request improves or enhances an existing implementation.

Comments

@ciband
Copy link
Contributor

ciband commented Dec 29, 2018

Is your feature request related to a problem? Please describe.
The hunter package manager is not ideal and is hard to work with. It also locks you into a particular version of the software, usually old.

Describe the solution you'd like
I would like to see the curl dependency converted to a git submodule for maximum flexibility.

Describe alternatives you've considered
Another option would be to use something other than curl as a submodule to accomplish the same thing.

Additional context
N/A

@sleepdefic1t
Copy link
Contributor

I'd be in favor of this.

What would the solution look like on our end using submodules?
Like, what directory should the submodule go in/where in the build process/etc?

@ciband
Copy link
Contributor Author

ciband commented Jan 2, 2019

It should follow the same pattern we use for other submodules. cpp-crypto/src is a good example of this.

In the specific case of curl, it would go in ./src/lib/curl. Ideally, we would build curl via cmake and add_subdirectory. The framework is there but curl is complex to build.

@faustbrian faustbrian added Type: Refactor The pull request improves or enhances an existing implementation. and removed 💭 help wanted labels Jan 4, 2019
@sleepdefic1t
Copy link
Contributor

@ciband
Was able to get rid of Hunter completely and use cURL as a submodule in:
https://github.com/sleepdefic1t/PSP-OS

Big refactor is coming soon to Cpp-Client and Cpp-Crypto,
so the main SDK's will be minimal and won't need cURL at all.
PSP's (Platform Support Packages) will implement architecture-dependent code like this soon.

@faustbrian We can probably close this out now since cURL will be dropped from Cpp-Client altogether.

@ghost
Copy link

ghost commented May 16, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants