Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS build failures in CircleCI #55

Closed
sleepdefic1t opened this issue Jan 12, 2019 · 4 comments
Closed

macOS build failures in CircleCI #55

sleepdefic1t opened this issue Jan 12, 2019 · 4 comments

Comments

@sleepdefic1t
Copy link
Contributor

Describe the bug

CircleCI builds fail for macOS.
This was discovered during #54

I can confirm that Cpp-Client builds and passes tests on my macOS system.

Further exacerbating this is that PR's do not appear to trigger macOS CI instances consistently.
PR's from @ciband do not trigger macOS CI builds.
I personally can trigger macOS builds by submitting PR's,
but I do not have the write access to rerun workflows in CircleCI.

To Reproduce

Submit a PR to the Cpp-Client Repo.

Expected behavior

CI should pass successfully on all platforms for all PR submissions.

@sleepdefic1t
Copy link
Contributor Author

Related Issue also discussed in ArkEcosystemArchive/cpp-crypto#27

@sleepdefic1t
Copy link
Contributor Author

#56 did not trigger CI builds for macOS, otherwise passes test.
#57, #58, and #59 (submitted myself) builds and passes all tests including macOS.

Additionally, the following two PR's (also submitted by me) in Cpp-Crypto trigger macOS builds which pass all tests including macOS:

Overall, macOS builds seem to fail sporadically.
That could just be something funky on CircleCI's end.

PR's from other users continue to not trigger macOS builds.
PR's from myself continue to trigger macOS builds.

@sleepdefic1t
Copy link
Contributor Author

Updates to #56 from @ciband have since triggered macOS builds, but subsequently fail.

@sleepdefic1t
Copy link
Contributor Author

These issues are most likely unrelated to Cpp-Client.

Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant