fix: remove "two" references #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly in docs and tests. These made it through after V1 was dropped. There's no reason to reference the distinction of "two" for API naming anymore.
ciband
approved these changes
Jan 12, 2019
|
Looks like we may have an issue with CI. Those macOS build failures are new for me. It says they fail on installing dependencies. Builds and passes all tests on my macOS system. |
|
You can try and re-trigger the workflow from circleci. That has worked for me when CI does something screwy.
…Sent from my iPhone
On Jan 11, 2019, at 20:23, Simon ***@***.***> wrote:
Looks like we may have an issue with CI.
Those macOS build failures are new for me.
It says they fail on installing dependencies.
It's not at all related to this PR though.
Builds and passes all tests on my macOS system.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@ciband I don't have write access to rerun workflows 🤷♂️ I created #55 to address this. This PR is good to go though @faustbrian, these CI failures aren't related to these changes. |
|
@faustbrian PR branch updated to match |
faustbrian
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR removes references to "two" pertaining to the API version.
There's no reason to reference the distinction of "two" for API naming anymore.
These "two" references were mostly in test method names, as well as a reference in 'docs/cpp.md'.
They snuck through during the V1 drop.
Types of changes
Checklist