Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

Reduce Factory duplication #245

Closed
faustbrian opened this issue May 15, 2020 · 0 comments · Fixed by #247
Closed

Reduce Factory duplication #245

faustbrian opened this issue May 15, 2020 · 0 comments · Fixed by #247
Assignees

Comments

@faustbrian
Copy link
Contributor

https://github.com/ArkEcosystem/platform-sdk/blob/master/packages/platform-sdk-ark/src/factory.ts

The factory that is provided by every package has quite a bit of duplication. Instead of each package shipping with its own factory, there will be a CoinFactory that handles the instantiation of the coin implementations.

import { CoinFactory } from "@arkecosystem/platform-sdk";
import ARK from "@arkecosystem/platform-sdk-ark";

await CoinFactory.construct(ARK, { ... });

This will reduce duplication quite a bit and reduce the overhead of what the coin implementations have to maintain.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant