Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

Make slip44 configurable #352

Closed
faustbrian opened this issue May 25, 2020 · 1 comment · Fixed by #402
Closed

Make slip44 configurable #352

faustbrian opened this issue May 25, 2020 · 1 comment · Fixed by #402
Assignees
@faustbrian
Labels
Type: Refactor The pull request improves or enhances an existing implementation.

Comments

@faustbrian
Copy link
Contributor

No description provided.

@faustbrian faustbrian added the Type: Refactor The pull request improves or enhances an existing implementation. label May 25, 2020
@faustbrian faustbrian self-assigned this May 25, 2020
@faustbrian faustbrian added this to the 1.0.0 milestone May 31, 2020
@ghost ghost mentioned this issue May 31, 2020
Closed
@faustbrian
Copy link
Contributor Author

The slip44 is part of the manifest for each coin and each network so it could be configured through https://github.com/ArkEcosystem/platform-sdk/blob/master/packages/platform-sdk/src/coins/config.ts

@faustbrian faustbrian mentioned this issue Jun 9, 2020
Merged
@ghost ghost mentioned this issue Jun 14, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@faustbrian faustbrian

Labels
Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(profiles): cover that custom slip44 can be used ArkEcosystemArchive/platform-sdk
1 participant
@faustbrian