Fix using strlen with non-NUL terminated string #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mattn
changed the title
SuperFola
reviewed
Oct 6, 2021
|
Thanks for your contribution! As for the label, as I understood the Hacktoberfest guidelines, this isn't needed since the whole repository is tagged hacktoberfest and hacktoberfest2021 :) |
|
Updated PR. I'll squash commits if you want. Thanks. |
|
Thanks for the fix Don't worry, I can squash and merge on my side. |
SuperFola
approved these changes
Oct 6, 2021
rstefanic
pushed a commit
to rstefanic/Ark
that referenced
this pull request
Dec 24, 2022
* Fix using strlen with non-NUL terminated string * NUL terminator for ARK_VERSION_STR Former-commit-id: 41623073a8d86ba2156d80579b57a64cf9763e1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARK_VERSION_STRis constaint string that does not contain NUL.Pleaes label this hacktoverfest2021 :)