Add KeepBranchesOnMailMissionCompletion #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a base-game issue where completing a branch mission via a MailServer erroneously clears out the branch missions of the next mission.
The short of it is: we delete these lines from
Hacknet.MailServer->doRespondDisplay
:Note that if
attemptCompleteMission
returnstrue
, theOS
'sactiveMission
andbranchMissions
have already been set to the values for the next mission by the mission completion code.Compatibility impact
The changes from this PR fix an issue with the base game's "ThemeHack"/"Naix" missions.
Extension behavior may also be altered, though I'm not aware of any Extensions intentionally using this behavior. Conversely, I am aware of one in-development Extension that includes a workaround for this issue.