Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to detect branch when switching from dirty repo to new fork of plugin #822

Closed
sprior opened this issue Feb 24, 2024 · 3 comments
Closed
Labels
bug Something isn't working resolved Issue is resolved

Comments

@sprior
Copy link

sprior commented Feb 24, 2024

What happened

With a fully up to date Klipper v0.12.0-114-ga77d0790/Moonraker v0.8.0-315-g119f579a/Fluidd v1.28.1

I've been trying to modify the source for klippain-shaketune to see if I can make it work with python 3.11 installed from source. Initially I installed from the original git repo and modified some files and update manager showed status as dirty. So I tried to go legit and fork the git repo. After making the appropriate install.sh changes to point to my fork I've installed and doing a git status in ~/klippain_shaketune indicates a clean repo. I confirmed that the update manager entry in moonraker.conf points to my fork so everything should be good, but update manager still shows:
Klippain-ShakeTune
?
Failed to detect git branch
Failed to detect repo url

And in my moonraker.log I'm seeing:
2024-02-23 23:25:17,119 [server.py:_initialize_component()] - Component [update_manager] failed post init
Traceback (most recent call last):
File "/home/pi/moonraker/moonraker/server.py", line 247, in _initialize_component
await ret
File "/home/pi/moonraker/moonraker/components/update_manager/update_manager.py", line 189, in component_init
await updater.initialize()
File "/home/pi/moonraker/moonraker/components/update_manager/git_deploy.py", line 51, in initialize
self._is_valid = storage["is_valid"]
KeyError: 'is_valid'

Pressing "Recover" didn't help, actually it hung.

Which I see in other issues like #821

I also found:
#820
which talks about a stale state loading from storage, but that issue is closed

Is there something I can do to manually clear out an old state from storage when I switch to a fork?

Client

Fluidd

Browser

Firefox

How to reproduce

See description, I think it's all there.

Additional information

No response

@sprior sprior added the bug Something isn't working label Feb 24, 2024
@Arksine
Copy link
Owner

Arksine commented Feb 24, 2024

Thanks. This should be resolved in 90e13c0

@Arksine Arksine added the resolved Issue is resolved label Feb 24, 2024
@Arksine
Copy link
Owner

Arksine commented Feb 24, 2024

Issue confirmed resolved, so I will close this.

@sprior
Copy link
Author

sprior commented Feb 24, 2024

Confirmed, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved Issue is resolved
Projects
None yet
Development

No branches or pull requests

2 participants