Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] Added artist column to Zune Desktop tracks list. Shows when tracks have different song artists. #101

Merged
merged 17 commits into from
Jun 14, 2022

Conversation

amaid
Copy link
Collaborator

@amaid amaid commented May 11, 2022

  • Added a new column on track collection on zune to display artists.
  • The artists are only displayed if a track has more than one artist excluding the target artist itself.
Multiple_artists_On_Tracks.mp4

@amaid amaid requested a review from Arlodotexe May 11, 2022 18:51
Copy link
Owner

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's showing when it shouldn't -- since all the names are the same in the screenshot below, we need to hide the column.

image

Repro:

  1. Set up a file based core (I had both taglib and file properties enabled)
  2. Select an artist
  3. Select an album
  4. Observe the bug

Alternate repro:

  1. Set up a file based core
  2. Once the zune shell loads, from the artist page, select any album
  3. Observe the bug

… listening to ArtistItemsCountChanged event.
Copy link
Owner

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a lingering bug with this.

  1. Set up a file core
  2. Load the Zune Desktop shell
  3. Go to the collection view
  4. Select an album first
  5. Observe the bug. Artist column is showing when it shouldn't, and shows double artists.

The problem can also be seen on any album in the "Albums" tab.

image

@Arlodotexe
Copy link
Owner

I also managed to get this exception:

  1. Set up a file core
  2. Load the Zune Desktop shell
  3. Go to the collection view
  4. Switch between albums during a file scan until the crash occurs.

image

@amaid
Copy link
Collaborator Author

amaid commented Jun 12, 2022

I also managed to get this exception:

  1. Set up a file core
  2. Load the Zune Desktop shell
  3. Go to the collection view
  4. Switch between albums during a file scan until the crash occurs.

image

Fixed

@amaid
Copy link
Collaborator Author

amaid commented Jun 12, 2022

There's still a lingering bug with this.

  1. Set up a file core
  2. Load the Zune Desktop shell
  3. Go to the collection view
  4. Select an album first
  5. Observe the bug. Artist column is showing when it shouldn't, and shows double artists.

The problem can also be seen on any album in the "Albums" tab.

image

Fixed

@Arlodotexe
Copy link
Owner

Linking #129

@Arlodotexe Arlodotexe changed the title Zune track collection artists column added. [improvement] Added artist column to Zune Desktop tracks list. Shows when tracks have different song artists. Jun 14, 2022
@Arlodotexe Arlodotexe merged commit 1b9ff2a into master Jun 14, 2022
@Arlodotexe Arlodotexe deleted the feature/track-collection-artist-column branch June 14, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants