Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Audio Metadata Scanner now returns multiple artists for a track (if any) #106

Merged
merged 8 commits into from
May 31, 2022
Merged

[fix] Audio Metadata Scanner now returns multiple artists for a track (if any) #106

merged 8 commits into from
May 31, 2022

Conversation

amaid
Copy link
Collaborator

@amaid amaid commented May 14, 2022 •
edited

Overview

This pull request is a:

Feature

Refactoring (no functional changes, no api changes)

Closes N/A

Refactored AudioMetadataScanner so that it returns more than 1 artists if they exist.

image
image
image
image

Checklist

Make sure your PR meets these requirements:

  • Based off latest master branch. Your branch must be up to date before closing.
  • Changes were tested and contain NO breaking changes or known regressions
  • Tests for bug fixes / features have been added (or this option is not applicable)
  • All new code has been documented (or this option is not applicable)
  • Headers have been added to all new source files (or this option is not applicable)

There are no breaking changes.

Other information

Its a change in the SDK but it will not affect Cores and Shell.

@amaid amaid requested a review from Arlodotexe May 14, 2022 10:50
Arlodotexe
Arlodotexe requested changes May 14, 2022
View reviewed changes
Copy link
Owner

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, but we need to set up the minimal unit tests to make sure this works and stays working as intended. Let's do that before closing the PR.

@Arlodotexe Arlodotexe changed the title Refactored MetadtaScanner to return multiple artists for a track (If any) [improvement] Refactored MetadataScanner to return multiple artists for a track (If any) May 20, 2022
@Arlodotexe Arlodotexe changed the title [improvement] Refactored MetadataScanner to return multiple artists for a track (If any) [improvement] Audio Metadata Scanner now returns multiple artists for a track (if any) May 23, 2022
Repository owner deleted a comment from azure-pipelines bot May 23, 2022
@Arlodotexe Arlodotexe changed the title [improvement] Audio Metadata Scanner now returns multiple artists for a track (if any) [fix] Audio Metadata Scanner now returns multiple artists for a track (if any) May 26, 2022
@Arlodotexe Arlodotexe merged commit da0016d into master May 31, 2022
@Arlodotexe Arlodotexe deleted the feature/multiple-artists-for-track branch May 31, 2022 20:47
@Arlodotexe Arlodotexe mentioned this pull request Jun 9, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amaid @Arlodotexe