Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH key name for different learning paths #108

Closed
odidev opened this issue Mar 31, 2023 · 3 comments
Closed

SSH key name for different learning paths #108

odidev opened this issue Mar 31, 2023 · 3 comments

Comments

@odidev
Copy link
Contributor

odidev commented Mar 31, 2023

I have raised the PR for changing key_name = “id_rsa” and linked all the ssh key generation with a ssh document present in install-guides.

A new PR which was raised and merged for mysql learning path. Key name in that is given as mysql_key and undone the previously merged changes of mysql learning path.

Can you please let me know if I need to follow the changes done in mysql learning path for all learning path or can I continue using key_name = “id_rsa” for future learning paths?

@armflorentlebeau
Copy link
Contributor

Hi,
I've been reviewing the mysql Learning Path while you were pushing your changes so I had to merge them. I may have kept the name mysql_key but don't mind reverting to id_rsa to be consistent with the other articles.
I will make a PR and let you know.
Florent

@odidev
Copy link
Contributor Author

odidev commented Apr 3, 2023

Thanks for the clarification. If required, I can raise PR for the same.

pareenaverma added a commit that referenced this issue Apr 3, 2023
Issue #108 Replace occurrences of my_sql SSH key
@pareenaverma
Copy link
Contributor

Closing this issue, as it has been addressed by PR #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants