Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GPU Monitoring module doesn't report GPU usage on postpone #142

Closed
Spiritreader opened this issue Jul 22, 2020 · 0 comments · Fixed by #252
Closed

New GPU Monitoring module doesn't report GPU usage on postpone #142

Spiritreader opened this issue Jul 22, 2020 · 0 comments · Fixed by #252
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Spiritreader
Copy link
Member

Describe the bug
When a timed theme switch is delayed due to high GPU usage, the old monitoring module logged this incident.
The new module has been rewritten more efficiently and does not yet implement this behavior.

Expected behavior
The new GPU monitoring module logs the GPU usage once after the threshold has been surpassed with a message similar to the old module, e.g

Logger.Info($"postponing theme switch ({gpuUsage}% / {ConfigBuilder.Config.GPUMonitoring.Threshold}%)");

Additional context
Affected module: GPUMonitorModuleV2.cs

@Spiritreader Spiritreader added enhancement New feature or request good first issue Good for newcomers version X labels Jul 22, 2020
Spiritreader added a commit that referenced this issue Sep 2, 2021
@Spiritreader Spiritreader linked a pull request Sep 2, 2021 that will close this issue
@Spiritreader Spiritreader moved this from To do to Done in AutoDarkMode X Beta 5 Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant