Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CommonJS modules with only module.exports and no require #219

Closed
ArnaudBuchholz opened this issue Jan 23, 2018 · 1 comment
Closed

Handle CommonJS modules with only module.exports and no require #219

ArnaudBuchholz opened this issue Jan 23, 2018 · 1 comment
Assignees
@ArnaudBuchholz
Labels
bug enhancement
Milestone
Release 0.2.4: At...

Comments

@ArnaudBuchholz
Copy link
Owner

In general, I need to upgrade the JavaScript detection.

When no require is used but module.exports is, there will be a problem
Some modules might contain no require and no exports

Those two cases are not handled properly.
@ArnaudBuchholz ArnaudBuchholz self-assigned this Jan 23, 2018
ArnaudBuchholz added a commit that referenced this issue Jan 30, 2018
@ArnaudBuchholz
New test case (#219)
e8769ed
ArnaudBuchholz added a commit that referenced this issue Jan 30, 2018
@ArnaudBuchholz
WIP (#219)
68784af
ArnaudBuchholz added a commit that referenced this issue Jan 30, 2018
@ArnaudBuchholz
Better handling or error cases, no require test case (#219)
2adf515
ArnaudBuchholz added a commit that referenced this issue Jan 30, 2018
@ArnaudBuchholz
Merges the two implementations in one (#219)
bc4c08b
ArnaudBuchholz added a commit that referenced this issue Jan 30, 2018
@ArnaudBuchholz
Exports might be a falsy value, improves switch (#219)
6da5797
@ArnaudBuchholz
Copy link
Owner Author

Algorithm merged and working fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArnaudBuchholz ArnaudBuchholz

Labels
bug enhancement
Projects
None yet
Milestone
Release 0.2.4: Attributes
Development

No branches or pull requests
1 participant
@ArnaudBuchholz