Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteCollection response should contain List type #49

Closed
Arnavion opened this issue Jul 22, 2019 · 0 comments
Closed

DeleteCollection response should contain List type #49

Arnavion opened this issue Jul 22, 2019 · 0 comments

Comments

@Arnavion
Copy link
Owner

Currently it contains the element type. Eg DeleteCollectionNamespacedPodResponse should have an OkValue(PodList) variant instead of OkValue(Pod)
Arnavion pushed a commit that referenced this issue Jul 22, 2019
Add Content-Type header to all requests with bodies.
3f4ec44 
All operations with requests bodies, except for patch requests, now add
a `Content-Type: application/json` header to the request.

The `Patch` struct is now generated as an enum of `Json`, `Merge` and
`StrategicMerge` variants, each wrapping a `serde_json::Value`.

Patch operations use the variant of the `Patch` struct to set the appropriate
`Content-Type` header.

This commit also fixes the response types of delete-collection operations to
contain the list type of the associated type, not the associated type itself.

Ref #43
Fixes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Arnavion