Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump base64 to 0.20 #130

Merged
merged 1 commit into from Dec 12, 2022
Merged

Bump base64 to 0.20 #130

merged 1 commit into from Dec 12, 2022

Conversation

jesperpedersen
Copy link
Contributor

No description provided.

@Arnavion
Copy link
Owner

base64::decode_config(base64::STANDARD) -> base64::decode_engine(&base64::engine::DEFAULT_ENGINE)

base64::encode_config(foo, base64::STANDARD) -> base64::encode_engine(foo, &base64::engine::DEFAULT_ENGINE)

Arnavion
Arnavion reviewed Dec 12, 2022
View reviewed changes
Cargo.toml Outdated
@@ -28,7 +28,7 @@ include = [
links = "k8s-openapi-0.16.0"

[dependencies]
base64 = { version = "0.13", default-features = false, features = [
base64 = { version = "0.20", default-features = false, features = [
"alloc", # for base64::decode_config and base64::encode_config
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update this comment for the new fn names.

@jesperpedersen
Copy link
Contributor Author

Ok, good to go

@jesperpedersen jesperpedersen mentioned this pull request Dec 12, 2022
Closed
@Arnavion
Copy link
Owner

Yeah, I guess that also works. I did the _config versions originally to be explicit about which config is being used, but it's kinda obvious anyway.

Thanks.

@Arnavion Arnavion merged commit abf7faf into Arnavion:master Dec 12, 2022
@jesperpedersen
Copy link
Contributor Author

Thanks !

@jesperpedersen jesperpedersen deleted the base64 branch December 13, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arnavion Arnavion Arnavion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesperpedersen @Arnavion