Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web service improvements #40

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Web service improvements #40

merged 2 commits into from
Mar 22, 2018

Conversation

CarlosGarciaHdez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #40 into master will increase coverage by 10.18%.
The diff coverage is 71.42%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #40       +/-   ##
=============================================
+ Coverage     69.38%   79.57%   +10.18%     
- Complexity       35       38        +3     
=============================================
  Files             9        9               
  Lines           147      142        -5     
  Branches          7        8        +1     
=============================================
+ Hits            102      113       +11     
+ Misses           41       24       -17     
- Partials          4        5        +1
Impacted Files Coverage Δ Complexity Δ
.../org/uniovi/i3a/incimanager/web/WebController.java 84.84% <71.42%> (-4.81%) 6 <0> (ø)
...ovi/i3a/incimanager/kafka/KafkaProduceFactory.java 100% <0%> (+100%) 4% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29635be...e00ae55. Read the comment docs.

@thewillyhuman thewillyhuman merged commit dce96cd into Arquisoft:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants