Send connection profile config as json and validate it

ArroyoSystems · Aug 23, 2023 · 005953f · 005953f
1 parent bee0867
commit 005953f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/arroyo-api/src/connection_profiles.rs b/arroyo-api/src/connection_profiles.rs
@@ -12,7 +12,9 @@ use crate::handle_db_error;
 use crate::queries::api_queries;
 use crate::queries::api_queries::DbConnectionProfile;
 use crate::rest::AppState;
-use crate::rest_utils::{authenticate, client, log_and_map, ApiError, BearerAuth, ErrorResp};
+use crate::rest_utils::{
+    authenticate, bad_request, client, log_and_map, ApiError, BearerAuth, ErrorResp,
+};
 
 impl TryFrom<DbConnectionProfile> for ConnectionProfile {
     type Error = String;
@@ -57,6 +59,11 @@ pub async fn create_connection_profile(
     let client = client(&state.pool).await.unwrap();
     let auth_data = authenticate(&state.pool, bearer_auth).await.unwrap();
 
+    connector_for_type(&req.connector)
+        .ok_or_else(|| bad_request("Unknown connector type".to_string()))?
+        .validate_config(&req.config)
+        .map_err(|e| bad_request(format!("Invalid config: {:?}", e)))?;
+
     let pub_id = generate_id(IdTypes::ConnectionProfile);
     api_queries::create_connection_profile()
         .bind(

diff --git a/arroyo-connectors/src/lib.rs b/arroyo-connectors/src/lib.rs
@@ -178,7 +178,8 @@ impl<C: Connector> ErasedConnector for C {
         Ok(self.config_description(self.parse_config(s)?))
     }
 
-    fn validate_config(&self, _: &serde_json::Value) -> Result<(), serde_json::Error> {
+    fn validate_config(&self, config: &serde_json::Value) -> Result<(), serde_json::Error> {
+        self.parse_config(config)?;
         Ok(())
     }
 

diff --git a/arroyo-console/src/routes/connections/ConfigureConnection.tsx b/arroyo-console/src/routes/connections/ConfigureConnection.tsx
@@ -55,7 +55,7 @@ const ClusterEditor = ({
           body: {
             name: d.name,
             connector: connector,
-            config: JSON.stringify(d),
+            config: d,
           },
         });