Add restarting state and pipeline restart API #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new state
Restarting
and a new apiPOST /pipeline/{id}/restart
which together allowing restarting pipelines. This can be used to restart a running pipeline (sometimes useful if it gets into some bad state that the system isn't able to automatically detect). But it can also be used for failed jobs, which currently cannot be recovered (without editing the db).Now, a failed pipeline can be restarted via the API like this:
There is also UI support to restart failed pipelines:
Restarting is a bit awkward to model in a reconciliation-based system like the controller; in general reconciliation requires a change to drive an operation. But for restarting, we want to force a state transition without actually changing any configuration.
This PR accomplishes that by adding
restart_nonce
fields on the job_configs and job_statuses tables. This is a number that can be incrementing in order to change the config while leaving everything the same.