Support joining updating data #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeisen
force-pushed
the
joining-updating
branch
3 times, most recently
from
0620971
to
b6c48ee
Compare
jacksonrnewhouse
approved these changes
Nov 29, 2023
| @@ -21,299 +25,506 @@ pub struct JoinWithExpiration< | |||
| left_expiration: Duration, | |||
| right_expiration: Duration, | |||
| processor: P, | |||
| _t: PhantomData<(K, T1, T2, Output)>, | |||
| pub _t: PhantomData<(K, P1, P2, InT1, InT2, T1, T2, Output)>, | |||
There was a problem hiding this comment.
I think it'd be a cleaner to just have a new() method that other parts of the code call, instead of making this pub or pub (crate)
jbeisen
force-pushed
the
joining-updating
branch
from
b6c48ee
to
288c02a
Compare
jbeisen
force-pushed
the
joining-updating
branch
from
288c02a
to
122896b
Compare
Operators that produce updating data (insert/update/delete) previously could not be upstream from the JoinWithExpiration operator. This change modifies the JoinWithExpiration operator to correctly handle updating data. All join types, excluding inner joins on non-updating inputs, now produce updating data. The bulk of the changes are in `join_with_expiration.rs`, where we transforms/coerces all data into updating data so that we reuse the same 4 join processors regardless of input type.
jbeisen
force-pushed
the
joining-updating
branch
from
122896b
to
bab51bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operators that produce updating data (insert/update/delete) previously could not be upstream from the JoinWithExpiration operator. This change modifies the JoinWithExpiration operator to correctly handle updating data.
All join types, excluding inner joins on non-updating inputs, now produce updating data.
The bulk of the changes are in
join_with_expiration.rs, where we transforms/coerces all data into updating data so that we reuse the same 4 join processors regardless of input type.Tested by adding new smoke tests and by running the queries through Flink and checking that the outputs are equivalent.