Add bad data option to create connection form #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeisen
commented
Dec 14, 2023
| readerSchema?: string; | ||
| /** Format: int32 */ | ||
| schemaId?: number | null; |
|
I think this could use more explanation in the UI about what this means and what the options are |
jbeisen
force-pushed
the
invalid-data
branch
3 times, most recently
from
0b42734
to
152090c
Compare
Add a bad data option selector to the Define schema stage of the create connection flow.
mwylde
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bad data option selector to the Define schema stage of the create connection flow.