Fix issues with enums in json form #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeisen
force-pushed
the
select-defaults
branch
2 times, most recently
from
8fc67b7
to
7d5f153
Compare
jbeisen
changed the title
mwylde
reviewed
Dec 14, 2023
jbeisen
force-pushed
the
select-defaults
branch
from
7d5f153
to
51b2fbd
Compare
Formik was not properly setting the values when switching between JSON shema 'oneof' variants. This adds a call to reset the field when switching variants. This change also removes the option of leaving optional enums as null, and instead defaults it to the 'default_value' (for string enums if defined), or the first oneof variant.
jbeisen
force-pushed
the
select-defaults
branch
from
51b2fbd
to
656a038
Compare
mwylde
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formik was not properly setting the values when switching between JSON shema 'oneof' variants. This adds a call to reset the field when switching variants.
This change also removes the option of leaving optional enums as null, and instead defaults it to the 'default_value' (for string enums if defined), or the first oneof variant.
For example: