Add autocomplete when creating connections and Kafka topic autocomplete #458
Conversation
|
Maybe we don't need this stracktrace 
|
|
The stacktrace is there because you're running with RUST_BACKTRACE enabled. It won't show up for users. |
|
Maybe limit the size of this and make it scrolling? 
|
| <UnorderedList | ||
| position={'absolute'} | ||
| top={20} | ||
| left={-3} | ||
| {...getMenuProps()} | ||
| bg={'gray.700'} | ||
| zIndex={100} | ||
| borderColor={'gray.500'} | ||
| borderWidth={'1px'} | ||
| borderRadius={8} | ||
| listStyleType={'none'} | ||
| w={'90%'} | ||
| display={isOpen && items.length > 0 ? 'block' : 'none'} | ||
| opacity={0.95} | ||
| overflow={'hidden'} | ||
| > |
There was a problem hiding this comment.
Have you considered using a component like this? I feel like it would solve some of this hacky positioning stuff.
There was a problem hiding this comment.
Yeah, I looked at that one. It didn't seem to support the behavior I wanted, where you're allowed to type something that is not included in the list. The closest it comes is "creatable items" where you can add something to the list, but that's an awkward UI experience I think. Building our own UI on top of downshift seemed like an easier, better supported option.
There was a problem hiding this comment.
Looking at the gif of the "creatable items" I think it looks ideal, and you can customize it to clearly say that the user is creating a new topic.
There was a problem hiding this comment.
That UI makes the list of items the source of truth, and the textbox is just referencing one of those. What I want is for the text box to be the source of truth, possibly filled in by the list of items.
mwylde
force-pushed
the
kafka_autocomplete
branch
from
14fefbc
to
62a5f2c
Compare
|
Updated with feedback. The list now scrolls, and I'm also filtering out internal kafka topics (the ones that start with |
This PR adds infrastructure for providing autocomplete of connection details, and an initial use case for Kafka topics.
It looks like this:
There are several pieces to the implementation:
/connector_profiles/{id}/autocompleteautocompletesupported by our JsonForm library that renders an Autocomplete widgetThe widget shows the status of the autocomplete fetch and reports errors if the fetch failed.