Validate schema and encoding issues when testing kafka connections #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
commented
Dec 19, 2023
| @@ -27,7 +27,7 @@ export const CreateProfile = ({ | |||
| const [error, setError] = useState<string | null>(null); | |||
| const [valid, setValid] = useState<boolean | null>(null); | |||
| const [validating, setValidating] = useState<boolean>(false); | |||
| const [state, setState] = useState<any | null>(null); | |||
| const state = useRef<any | null>(null); | |||
There was a problem hiding this comment.
fixes a bug introduced in #454 which caused changes to the form to not always propagate to the state that was actually saved
mwylde
force-pushed
the
autodetect_schema
branch
from
a520718
to
65fd884
Compare
mwylde
force-pushed
the
autodetect_schema
branch
from
65fd884
to
bdad9b8
Compare
mwylde
force-pushed
the
autodetect_schema
branch
2 times, most recently
from
8703b77
to
0e7e658
Compare
mwylde
force-pushed
the
autodetect_schema
branch
from
0e7e658
to
0adfc39
Compare
jacksonrnewhouse
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of the connection creation flow we have a testing process, which currently for Kafka is able to validate issues connecting to and reading messages. However, it does not currently validate that the messages themselves are well-formed according to the format that's been configured.
This adds such support, which can catch issues like the wrong format being selected or incorrectly selecting/not selecting confluent schema registry.