Handle empty strings in JSON form #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
reviewed
Dec 20, 2023
| const onChangeWrapper = (e: React.ChangeEvent<any>) => { | ||
| onChange(e); | ||
|
|
||
| if (resetField && e.target.value == '') { |
There was a problem hiding this comment.
Should this be before the parent onchange? For the connection page, we rely on onchange to synchronize the current state for validation
There was a problem hiding this comment.
The issue that since we want to set the value to undefined, we need to do that after onChange sets it to the empty string.
jbeisen
force-pushed
the
json-form-empty-string
branch
2 times, most recently
from
74812d6
to
ab6c543
Compare
jbeisen
commented
Dec 21, 2023
| @@ -659,7 +669,7 @@ export function FormInner({ | |||
| // @ts-ignore | |||
| onChange({ target: { name: path, value: {} } }); | |||
| } | |||
| }, [schema]); | |||
| }, []); | |||
There was a problem hiding this comment.
@mwylde This should make it add the empty object on only the first render
In the StringWidget component, if the string is empty then reset the field to undefined. This prevents validation false positives. Also use the JSON schema 'dependentRequired' keyword in the Confluent schema, and surface object-level formik errors.
jbeisen
force-pushed
the
json-form-empty-string
branch
from
ab6c543
to
82b986e
Compare
mwylde
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the StringWidget component, if the string is empty then reset the field to undefined. This prevents validation false positives.
Also use the JSON schema 'dependentRequired' keyword in the Confluent schema, and surface object-level formik errors.