Resolve rule params with default value

ArtARTs36 · Sep 3, 2023 · 45aac08 · 45aac08
1 parent 22b22c0
commit 45aac08
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/src/Application/Rule/Rules/HasChangesRule.php b/src/Application/Rule/Rules/HasChangesRule.php
@@ -17,7 +17,7 @@
 use ArtARTs36\MergeRequestLinter\Domain\Rule\Rule;
 use ArtARTs36\MergeRequestLinter\Domain\Rule\RuleDefinition;
 
-#[Description('Merge Request must have changes in {files}.')]
+#[Description('Merge Request must have {changes}.')]
 class HasChangesRule implements Rule
 {
     public const NAME = '@mr-linter/has_changes';

diff --git a/src/Shared/Reflection/ParameterMapBuilder.php b/src/Shared/Reflection/ParameterMapBuilder.php
@@ -24,7 +24,15 @@ public function build(Instantiator $constructor, array $params): array
         $args = [];
 
         foreach ($constructor->params() as $paramName => $param) {
-            $args[$paramName] = $this->argResolver->resolve($param->type, $params[$paramName] ?? null);
+            $val = null;
+
+            if (! array_key_exists($paramName, $params) && $param->hasDefaultValue) {
+                $val = $param->getDefaultValue();
+            } else {
+                $val = $this->argResolver->resolve($param->type, $params[$paramName] ?? null);
+            }
+
+            $args[$paramName] = $val;
         }
 
         return $args;

diff --git a/tests/Unit/Application/Rule/Rules/TitleStartsWithTaskNumberRuleTest.php b/tests/Unit/Application/Rule/Rules/TitleStartsWithTaskNumberRuleTest.php
@@ -47,6 +47,13 @@ public function providerForTestLint(): array
                 'projectCodes' => ['TASK'],
                 'expectedNotes' => ['Title must starts with task number of projects [TASK]'],
             ],
+            [
+                $this->makeMergeRequest([
+                    'title' => 'TASK-1 project',
+                ]),
+                'projectCodes' => ['TASKA'],
+                'expectedNotes' => ['Title starts with task number of unknown project "TASK"'],
+            ],
         ];
     }