Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix NativeJsonDecoder #30

Merged
merged 8 commits into from
Feb 15, 2023
Merged

[Bug] Fix NativeJsonDecoder #30

merged 8 commits into from
Feb 15, 2023

Conversation

ArtARTs36
Copy link
Owner

Fixed

  • Fix NativeJsonDecoder

Added

  • Some tests

@ArtARTs36 ArtARTs36 added Bug Something isn't working Tests labels Feb 15, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 22.13% // Head: 23.01% // Increases project coverage by +0.87% 🎉

Coverage data is based on head (7313c96) compared to base (55f9c1c).
Patch coverage: 28.12% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
+ Coverage     22.13%   23.01%   +0.87%     
- Complexity      810      821      +11     
============================================
  Files           225      225              
  Lines          2281     2303      +22     
============================================
+ Hits            505      530      +25     
+ Misses         1776     1773       -3     
Impacted Files Coverage Δ
src/Infrastructure/Container/MapContainer.php 100.00% <ø> (ø)
...astructure/RequestFetcher/MemoryRequestFetcher.php 100.00% <ø> (+100.00%) ⬆️
src/Presentation/Console/Command/Command.php 0.00% <0.00%> (ø)
...rc/Presentation/Console/Command/InstallCommand.php 41.17% <0.00%> (ø)
...esentation/Console/Interaction/WorkDirResolver.php 0.00% <0.00%> (ø)
src/Presentation/Console/Output/ConsoleLogger.php 0.00% <0.00%> (ø)
src/Shared/DataStructure/Arrayee.php 0.00% <ø> (ø)
.../Infrastructure/Text/Decoder/NativeJsonDecoder.php 85.71% <66.66%> (+85.71%) ⬆️
...Infrastructure/Text/Decoder/SymfonyYamlDecoder.php 77.77% <100.00%> (+77.77%) ⬆️
src/Presentation/Console/Command/LintCommand.php 45.23% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ArtARTs36 ArtARTs36 merged commit 8f58d23 into master Feb 15, 2023
@ArtARTs36 ArtARTs36 deleted the add-tests branch February 16, 2023 02:40
@mr-linter-bot
Copy link

mr-linter-bot commented Jul 29, 2023

I found 2 notes in your Pull Request:

  • The description must have a link to Jira on domain "jira.host.name"
  • Changelog must be contained new tag with heading level 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants