Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Suppress error on non-critical rules #48

Merged
merged 32 commits into from
May 26, 2023
Merged

Conversation

ArtARTs36
Copy link
Owner

@ArtARTs36 ArtARTs36 commented May 26, 2023

Added

  • Suppress error on non-critical rules via rule option critical: false
  • Added option stop_on_failure for stop linter on first failure
  • Added option stop_on_warning for stop linter on first warning

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Patch coverage: 51.53% and project coverage change: +0.03 🎉

Comparison is base (1750a0a) 50.35% compared to head (f3b6f92) 50.39%.

❗ Current head f3b6f92 differs from pull request most recent head a0ccce2. Consider uploading reports for the commit a0ccce2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
+ Coverage     50.35%   50.39%   +0.03%     
- Complexity     1164     1193      +29     
============================================
  Files           274      276       +2     
  Lines          3374     3457      +83     
============================================
+ Hits           1699     1742      +43     
- Misses         1675     1715      +40     
Impacted Files Coverage Δ
src/Application/Linter/LinterFactory.php 0.00% <0.00%> (ø)
...pplication/Linter/TaskHandlers/LintTaskHandler.php 0.00% <0.00%> (ø)
src/Application/Rule/Rules/MockRule.php 0.00% <0.00%> (ø)
src/Domain/Configuration/Config.php 0.00% <0.00%> (ø)
...onfiguration/Loader/Mapper/ArrayConfigHydrator.php 0.00% <0.00%> (ø)
src/Infrastructure/Rule/Resolver.php 0.00% <0.00%> (ø)
src/Presentation/Console/Output/ConsoleLogger.php 94.73% <ø> (-0.72%) ⬇️
src/Presentation/Console/Printers/NotePrinter.php 0.00% <0.00%> (ø)
.../Presentation/Console/Printers/RuleInfoPrinter.php 0.00% <0.00%> (ø)
src/Shared/DataStructure/Arrayee.php 93.10% <0.00%> (-6.90%) ⬇️
... and 10 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ArtARTs36 ArtARTs36 changed the title Non critical rule [Feature] Suppress error on non-critical rules May 26, 2023
@ArtARTs36 ArtARTs36 merged commit 5e9a584 into master May 26, 2023
2 checks passed
@ArtARTs36 ArtARTs36 deleted the non-critical-rule branch July 29, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants