Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add IsNumberEvaluator #66

Merged
merged 13 commits into from
Sep 13, 2023
Merged

[Feature] Add IsNumberEvaluator #66

merged 13 commits into from
Sep 13, 2023

Conversation

ArtARTs36
Copy link
Owner

Added

  • Added evaluator isNumber
  • Added evaluator containsNumber

@mr-linter-bot
Copy link

mr-linter-bot commented Sep 13, 2023

I didn't find any notes in your Pull Request.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.34% 🎉

Comparison is base (7edd54a) 63.27% compared to head (9e856d5) 63.61%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #66      +/-   ##
============================================
+ Coverage     63.27%   63.61%   +0.34%     
- Complexity     1603     1604       +1     
============================================
  Files           317      317              
  Lines          5135     5134       -1     
============================================
+ Hits           3249     3266      +17     
+ Misses         1886     1868      -18     
Files Changed Coverage Δ
...lication/Rule/Rules/ChangelogHasNewReleaseRule.php 97.36% <ø> (ø)
...Rules/ChangelogHasNewReleaseRule/ReleaseParser.php 96.00% <ø> (ø)
...ion/Evaluators/Strings/ContainsNumberEvaluator.php 100.00% <100.00%> (ø)
...Condition/Evaluators/Strings/IsNumberEvaluator.php 100.00% <100.00%> (ø)
...tion/Rule/Rules/BranchStartsWithTaskNumberRule.php 100.00% <100.00%> (+20.83%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArtARTs36 ArtARTs36 merged commit c25de67 into master Sep 13, 2023
5 checks passed
@ArtARTs36 ArtARTs36 deleted the is-number-evaluator branch September 13, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants