Splinemesh creation tool upgrade #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteihis
changed the title
|
The last one is more of a philosophical update.... |
Sailsman63
requested changes
Feb 20, 2020
|
Sorry for the delay. I finally got around to reviewing the details here. mostly looks good. See review comment for the one concern I have. |
Sailsman63
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the primitives it caught my eye, that spline meshes are not shown during creation whereas primitives are. Assuming, that the reason to that would have been processing power, when the code was written, I'd think those days are ancient history now. So here's what I got:
Changes:
As I tested with u and v values, that I'd believe to be typical (up to 100 or so), I can't say for sure, that I would have seen any more delay, than when drawing primitives.