CreatePolygonTool upgrade #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sailsman63
requested changes
Mar 12, 2020
| sine[i] = Math.sin((i+0.5)*2.0*Math.PI/sides); | ||
| sine[i] = 1e-10*Math.round(sine[i]*1e10); | ||
| sine[i] = Math.sin((i+0.5)*2.0*Math.PI/sides); | ||
| sine[i] = 1e-10*(Math.round(sine[i]*1e10)); |
There was a problem hiding this comment.
Only thing I've done so far: you've got a redundant pair of parentheses here.
There was a problem hiding this comment.
Oops. I tried somethig different here, this happened at returning the original.
| vertex[i].x = sine[i]*xscale; | ||
| vertex[i].y = -cosine[i]*yscale; | ||
| } | ||
| ((Mesh)(objInfo.object)).setVertexPositions(vertex); |
There was a problem hiding this comment.
And another here. objectInfo.object does not need to be wrapped.
|
I've come down on the side of consistency. I think we'll be better off with this than without. |
peteihis
force-pushed
the
create_polygon
branch
from
11d2a3a
to
ec9ea02
Compare
|
Fixed. |
Sailsman63
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to work with the same logic as the primitives and Spline Mesh. Resolves #156.
Let me know if you find anything funny, the modifications were prettey heavy.