New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major NAB updates #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as usual, @tomquirk - see some minor comments, otherwise happy to merge!
test.py
Outdated
self.assertEqual(name, '2010.01.01 - 2012.04.13.qif') | ||
|
||
name = qif.get_qif_name('1 Jan 10', '13 Apr 12') | ||
self.assertEqual(name, '2010.1.1 - 2012.4.13.qif') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be changed back to the exiting functionality, where it outputs 2010.01.01
instead of 2010.1.1
?
lib/browser.py
Outdated
print('\tOK') | ||
|
||
return b | ||
|
||
|
||
def get_all_transactions(b, account, start_date): | ||
|
||
TRANSACTIONS_PER_PAGE = 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably move TRANSACTIONS_PER_PAGE
to file-level const
@ArtS, just realised we're passing datetime objects into getQifName lol. I've fixed that function and updated the tests |
As discussed, all fixed and QIF functionality remains!
See last pull request for more details.
Additionally:
autopep8
Fixes #1
Fixes #2
Fixes #3
@ArtS