Skip to content
This repository has been archived by the owner on Nov 22, 2020. It is now read-only.

Introduce AlertTypeNone, enableDebug and forceAlert #56

Merged
merged 2 commits into from Sep 25, 2014

Conversation

jedi4ever
Copy link
Contributor

This PR enables:

  • AlertTypeNone: in our case we don't want to have an alert for Patch update only for Minor and Major
  • setEnableDebug: this logs the json & URL used to connect to the iTunes store. Handy if you are tracking why it can't be find a version
  • setForceAlert: sometimes you want to see the alert regardless what your app version in the appstore is. This allows you to force this. Handy if no version are in the Store yet.

@ArtSabintsev
Copy link
Owner

Hey @jedi4ever: Thanks for the PR.

I'll take a look at it today in detail when I have a bit more time.

@jedi4ever
Copy link
Contributor Author

@ArtSabintsev any update? thanks for your time.

@ArtSabintsev
Copy link
Owner

Yes. Will look at it tonight. Got hung up with my main project. I need to push an update to Harpy as is, so I'll bundle them together.

@ArtSabintsev
Copy link
Owner

Sorry - didn't get time this evening. Will do it first thing when I get into the office.

@ArtSabintsev
Copy link
Owner

So I took a look at the additions. Something in there breaks the lib's functionality - i.e., the alert never pops anymore. If you fix it, I'll take a look at it again.

Closing the issue now.

Also, I will add in HarpyAlertTypeNone and the enableDebug on my own with pulling the request. I'll credit you in the change.

Thanks for those additions.

@ArtSabintsev
Copy link
Owner

Oh you know, what, nevermind. I think I broke something when I was adding my own change. Reopening it.

@ArtSabintsev ArtSabintsev reopened this Sep 25, 2014
ArtSabintsev added a commit that referenced this pull request Sep 25, 2014
Introduce AlertTypeNone, enableDebug and forceAlert
@ArtSabintsev ArtSabintsev merged commit a1ea096 into ArtSabintsev:master Sep 25, 2014
@ArtSabintsev
Copy link
Owner

Pilling this request, but overriding it with some changes that I've made locally. I also removed the forceAlert option, as I didn't really like how it was implemented. I may add something similar down the road.

Your name was added tot he README and CONTRIBUTIONS list.

Thanks for your help!

@ArtSabintsev
Copy link
Owner

ok, all done. Everything is now live!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants