Delegate for latest version installed and check for how long current app has been released #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtSabintsev
requested changes
Nov 11, 2016
| @@ -538,12 +557,19 @@ fileprivate extension Siren { | |||
| return url | |||
| } | |||
|
|
|||
| func daysSince(lastVersionCheckPerformed lastCheckDate: Date) -> Int { | |||
| func daysSince(_ date: Date) -> Int { | |||
There was a problem hiding this comment.
Can you do me a favor and rename the method's so their signature looks as follows:
func days(since date:)
| return components.day! | ||
| } | ||
|
|
||
| func daysSince(dateString: String) -> Int? { | ||
| let dateformatter = DateFormatter() |
There was a problem hiding this comment.
DateFormatter's, at least the ObjC Foundation NSDaeFormatter is notoriously expensive to initialize. Can we place the dateFormatter initialization and basic (non-dateString) configuration in a static func?
| return components.day! | ||
| } | ||
|
|
||
| func daysSince(dateString: String) -> Int? { |
There was a problem hiding this comment.
Can you do me a favor and rename the method's so their signature looks as follows:
func days(since dateString:)
|
All feedback addressed. |
|
Looks good! Will merge and may make one stylistic tweak. I'll post back here when this is available via CocoaPods (should be soon) |
|
This is now available in Siren 1.1.0. Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
SirenDelegateto notify when the check finished and the latest version is already installed.showAlertAfterCurrentVersionHasBeenReleasedForDayswhich can be set to a number of days and the update alert then only shows up if the current version has already been released for the set number of days.